Moved get_container_run_config method to interface.
Using the get_container_run_config at all the places.
Fixed an issue in run_command to get spec, icon etc
Why
Different container engine will need different configs. Moving this to interface helps to separate this concern to interface implementation.
How
-
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Shouldn't since it is only a refactoring.
Database Migrations
Env Config
Relevant Docs
-
Related Issues or PRs
-
Dependencies Versions
-
Notes on Testing
Tested both workflow run and hitting the api to get ICON.
Screenshots
Checklist
I have read and understood the [Contribution Guidelines]().
What
Why
How
-
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Database Migrations
Env Config
Relevant Docs
-
Related Issues or PRs
-
Dependencies Versions
-
Notes on Testing
Screenshots
Checklist
I have read and understood the [Contribution Guidelines]().