search

Zirak / SO-ChatBot

Other
124 stars 60 forks source link

Add demo command #169

Closed SomeKittens closed 8 years ago

SomeKittens commented 10 years ago

Collects JSFiddle/CodePen/JSBin/etc demos from the room.

No idea what we'll do with the collection (gallery in room rules?) but it'll be fun.

Sorry about the multiple commits, this was all done through the web interface as I don't have access to a computer with git right now.

SomeKittens commented 10 years ago

Also: I can add anyone who wants to the Firebase DB.

Shmiddty commented 10 years ago

Don't forget plnkr.co On Jan 24, 2014 6:05 PM, "Randall Koutnik" notifications@github.com wrote:

Collects JSFiddle/CodePen/JSBin/etc demos from the room.

No idea what we'll do with the collection (gallery in room rules?) but it'll be fun.

Sorry about the multiple commits, this was all done through the web

interface as I don't have access to a computer with git right now.

You can merge this Pull Request by running

git pull https://github.com/SomeKittens/SO-ChatBot master

Or view, comment on, or merge it at:

https://github.com/Zirak/SO-ChatBot/pull/169 Commit Summary

  • Merge pull request #1 from Zirak/master
  • Added demo plugin
  • Added Firebase loading

File Changes

  • A source/plugins/demo.jshttps://github.com/Zirak/SO-ChatBot/pull/169/files#diff-0(17)

Patch Links:

— Reply to this email directly or view it on GitHubhttps://github.com/Zirak/SO-ChatBot/pull/169 .

SomeKittens commented 10 years ago

@Shmiddty It logs whatever the content of the message is (including context about the demo) so ALL THE SITES are included.

AmaanC commented 10 years ago

So it captures links that aren't demos too?

benjamingr commented 10 years ago

Sure

SomeKittens commented 10 years ago

@AmaanC It captures everything for now, I figure it's free, why not stash as much as we can (also capturing the context of the demo, etc.)

For instance:

!!demo plunkr.com/pants Some sample e2e tests

Otherwise, we'd see a really boring application and miss the real point.

benjamingr commented 10 years ago

Are we sure about the firebase storage? Also, wouldn't there be issues with people cloning the bot (and getting the same storage) the way it's currently implemented?

SomeKittens commented 10 years ago

Firebase is a stop-gap measure between localStorage and Node storage so I could start storage in the cloud. (The original point is to collect demos to show my class).

Yeah, clones will also save to Firebase. Suggestions?

benjamingr commented 10 years ago

What's wrong with localStorage or indexedDb again?

SomeKittens commented 10 years ago

I can't access them at-will to pull demos. !!demo (with no args) could pull the latest demos, but I like being able to sort through them.

SomeKittens commented 9 years ago

Revisiting: SavingDemos++ Firebase, not sure.

Zirak commented 8 years ago

SomeKittens said he's uninterested, so closing.