Zirak / SO-ChatBot

Other
124 stars 60 forks source link

Export import #215

Open BobVul opened 10 years ago

BobVul commented 10 years ago

Add export and import commands using the GitHub Gist API for storage. Issue #158.

BobVul commented 10 years ago

import: http://chat.stackexchange.com/transcript/message/17606164#17606164

export: http://chat.stackexchange.com/transcript/118?m=17605797#17605797, http://chat.stackexchange.com/transcript/message/17606164#17606164

allquixotic commented 10 years ago

+1

drpatil78 commented 10 years ago

+1

SomeKittens commented 10 years ago

+1

benjamingr commented 10 years ago

I think that clearing the memory should automatically back it up to a gist to prevent mishaps.

Other than that good commit, clean.

BobVul commented 10 years ago

@benjamingr I'm not sure what would be the best way to implement that. Extract export into a separate function, or chain the command?

var exportResult = bot.commands['export'].exec();

bot.memory.clear();

return exportResult + ' Bot memory cleared. Please restart the bot.';

Might also be a good idea to clear before importing new data, since the import .save() doesn't clear/overwrite bot_ localStorage entries that don't exist in the new data.

AmaanC commented 10 years ago

Yeah, an import should probably clear old data On Sep 11, 2014 2:55 PM, "Bob" notifications@github.com wrote:

@benjamingr https://github.com/benjamingr I'm not sure what the best way to implement that is. Extract export into a separate function, or chain the command?

var exportResult = bot.commands['export'].exec(); return exportResult + ' Bot memory cleared. Please restart the bot.';

Might also be a good idea to clear before importing new data, since the import .save() doesn't clear/overwrite bot_ localStorage entries that don't exist in the new data.

— Reply to this email directly or view it on GitHub https://github.com/Zirak/SO-ChatBot/pull/215#issuecomment-55240302.