search

Zirak / SO-ChatBot

Other
124 stars 62 forks source link

Fix welcome message #273

Closed erikroyall closed 8 years ago

erikroyall commented 8 years ago

Fix your code thx

ralt commented 8 years ago

Please don't open PRs that break working code.

kthx.

ralt commented 8 years ago

For the record, after your PR, she would say "Pleasedon't ask if you can ask" instead of "Please don't ask if you can ask".

AmaanC commented 8 years ago

I think you're misreading it, Florian. His change fixes that. Here's an example of the current behaviour: http://chat.stackoverflow.com/transcript/message/29080459#29080459

On Wed, Mar 2, 2016 at 2:05 PM, Florian Margaine notifications@github.com wrote:

For the record, after your PR, she would say "Pleasedon't ask if you can ask" instead of "Please don't ask if you can ask".

— Reply to this email directly or view it on GitHub https://github.com/Zirak/SO-ChatBot/pull/273#issuecomment-191128219.

ralt commented 8 years ago

I remember fixing that here, so, sup?

ralt commented 8 years ago

I have been shown to be wrong, since @Zirak somehow lost my commit.

Reopening.

Zirak commented 8 years ago

Thanks for the PR! Could you squash your commits so there'll only be one?

Sorry @ralt, it may have been lost in the browserify merge.

erikroyall commented 8 years ago

Done.

Zirak commented 8 years ago

Muchas gracias.