Zirak / SO-ChatBot

Other
124 stars 60 forks source link

Fix /urban to use HTTPS #291

Closed FirstWhack closed 7 years ago

FirstWhack commented 7 years ago

Fixed the urban command, it was a simple http/https issue since it's cors. Should work now I tested in the sandbox

tentonaxe commented 7 years ago

"since it's cors." isn't it jsonp?

FirstWhack commented 7 years ago

Yes, it's jsonp

rlemon commented 7 years ago

looks good, but I'll probably have to rebuild master.min, no telling what kinda shifty Easter eggs you hid in there. 😉

FirstWhack commented 7 years ago

Smart man.

On Aug 31, 2017 10:59 AM, "Robert Lemon" notifications@github.com wrote:

looks good, but I'll probably have to rebuild master. no telling what kinda shifty Easter eggs you hid in there. 😉

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Zirak/SO-ChatBot/pull/291#issuecomment-326342308, or mute the thread https://github.com/notifications/unsubscribe-auth/AERjJxMOOO8w1PRKehHJZ74eB2F8CvuPks5sdthggaJpZM4PAbPy .

FirstWhack commented 7 years ago

Rahhh /urban

Zirak commented 7 years ago

Sorry I'm a tard! Next time ping me in chat and I'll merge in a sec.