Zirak / SO-ChatBot

Other
124 stars 60 forks source link

Update welcome message #301

Closed kendfrey closed 6 years ago

kendfrey commented 6 years ago

I've made some changes to the welcome message, including:

Example can be seen at https://chat.stackoverflow.com/transcript/message/42342257#42342257

Feel free to berate me on the wording, or indeed to think that I did fine.

benjamingr commented 6 years ago

FWIW users already get a pretty big popup when they join chat apparently that tells them to report issues -

Zirak commented 6 years ago

Looks good, thanks! Just one small thing: could you just change the double quotes to singles?

kendfrey commented 6 years ago

@Zirak I purposely switched to double quotes because the string contains single quotes. Are you seriously suggesting it's better to have to escape them?

Zirak commented 6 years ago

@kendfrey That's the style guide, single quotes, for better and for worse.

kendfrey commented 6 years ago

In that case, you can expect a begrudging commit from me later today.

Zirak commented 6 years ago

Thanks @kendfrey!