thehumandistraction
commented
4 years ago Actually, it looks like I didn't test this properly enough as there seems to be a larger issue with flac2all as a whole. While initially copy works properly after the change in shell.py, it seems to fail after it goes through a couple of tracks and copyable files:
UTC~20:44:35: We have 1487 flac files to convert
UTC~20:44:35: We have 191 non-flac files to copy across
UTC~20:44:35: Spawning execution process
UTC~20:44:35: Processing: 01-take-on-me.flac target: vorbis
UTC~20:44:35: /media/data-disk/tunes/.directory => ./vorbis
UTC~20:44:36: /media/data-disk/tunes/five-iron-frenzy-between-the-pavement-and-the-stars-wav.zip => ./vorbis
UTC~20:44:36: /media/data-disk/tunes/world-is-square-stay-awhile-and-listen-wav.zip => ./vorbis
UTC~20:44:37: Processing: 06-cry-wolf.flac target: vorbis
UTC~20:44:38: /media/data-disk/tunes/world-of-warcraft-battle-for-azeroth-wav.zip => ./vorbis
UTC~20:44:38: /media/data-disk/tunes/a-ha/the-singles-1984-2004/AlbumArtSmall.jpg => ./vorbis/a-ha/the-singles-1984-2004
UTC~20:44:39: /media/data-disk/tunes/a-ha/the-singles-1984-2004/cover.jpg => ./vorbis/a-ha/the-singles-1984-2004
UTC~20:44:39: /media/data-disk/tunes/a-ha/the-singles-1984-2004/Folder.jpg => ./vorbis/a-ha/the-singles-1984-2004
Traceback (most recent call last):
File "/bin/flac2all", line 11, in <module>
load_entry_point('flac2all==5.2', 'console_scripts', 'flac2all')()
File "/usr/lib/python3.8/site-packages/flac2all_pkg/__init__.py", line 440, in main
threaded_encode()
File "/usr/lib/python3.8/site-packages/flac2all_pkg/multiprocess_encode.py", line 141, in encode
copytarget(srcfile, outdir)
File "/usr/lib/python3.8/shutil.py", line 409, in copy
copyfile(src, dst, follow_symlinks=follow_symlinks)
File "/usr/lib/python3.8/shutil.py", line 259, in copyfile
with open(src, 'rb') as fsrc, open(dst, 'wb') as fdst:
FileNotFoundError: [Errno 2] No such file or directory: './vorbis/brave-saint-saturn/anti-meridian'
UTC~20:44:40: Processing: 11-crying-in-the-rain.flac target: vorbis
Specifically, flac2all seems to get confused and mixes up the filename with the album directory name. https://imgur.com/a/EjDkehk
ZivaVatra
cleinias
mnhauke
MPereckas
Greetings,
In the latest version 5.1 the copy function is broken due to
stringbeing called rather thanstrin shell.py. This causes flac2all to hang once all music files have been processed. This happens the first time it comes across a file it intends to copy.The specific error can be seen when trying to copy cover art as it processes it's first album:
Changing line 45 from:
if (string.find(os.path.split(indir)[0], dirpath) != -1):to:
if (str.find(os.path.split(indir)[0], dirpath) != -1):fixes flac2all and copy functions as it should.
This was tested on an up-to-date Arch Linux system with the latest package from AUR.