search

Ziyang-98 / pe

0 stars 0 forks source link

Ingredient name could include symbols. #5

Open Ziyang-98 opened 4 years ago

Ziyang-98 commented 4 years ago

I think for ingredients, it is safe to say that there are no ingredients with symbols in them. Perhaps it would be better to ensure that the name of the ingredient is alphanumeric.

Screenshot 2020-11-13 at 5.03.26 PM.png

nus-se-bot commented 4 years ago

Team's Response

This is intended behaviour. For instance, users might want an ingredient like Milk (Low Fat). We did not feel a need to impose additional restrictions on how users can name their items.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Same as #6, this is more of acceptance testing. I feel that the justification provided is not sufficient since the ingredient can simply be called Low Fat Milk. As such, I feel that it would be more apt to only allow alphanumeric characters, similar to how AB-3 limits the names of a Person to only contain alphanumeric characters.