search

Zizaco / confide

Confide is a authentication solution for Laravel 4
1.19k stars 258 forks source link

Adding and loading options from config #427

Open wesleymilan opened 10 years ago

wesleymilan commented 10 years ago

I'd just added the username_type and validation rules into config file to avoid the needs of extend or overwrite the Zizaco classes. This can turn easier to setup and modify rules while using confide.

Thanks for do it, Confide is a great package.

Regards

coveralls commented 10 years ago

Coverage Status

Coverage decreased (-9.86%) when pulling 8b19f79fc4435987d75a3562ce985a5264659a51 on wesleymilan:master into c1280c45a60962c3506cecbea6b238c9ccf58083 on Zizaco:master.

coveralls commented 10 years ago

Coverage Status

Coverage decreased (-9.66%) when pulling 0b1a8bddeaa4578cdd92c26e456905a52ce1a625 on wesleymilan:master into c1280c45a60962c3506cecbea6b238c9ccf58083 on Zizaco:master.

Zizaco commented 10 years ago

I'm not exactly sure if it's better to have the validation rules as configs. If an application have different business rules of how a valid user should look a like, then it's a better idea to have a class to do it.

Using the config files to do this seems like a bad idea to me :(

Zizaco commented 10 years ago

Although the validation in config, to save the confirmation DateTime seems a pretty good idea. I liked it.

But I didn't get why the setTimezone is necessary. Can you explain to me?