Zizaco / confide

Confide is a authentication solution for Laravel 4
1.19k stars 258 forks source link

Confusing duplicate credentials message/handling? #470

Open nextpulse opened 9 years ago

nextpulse commented 9 years ago

The code distinctly separate username, password message for all forms - except when there is a duplicate username or email.

From a user perspective, it is very confusing:

"The credentials provided have already been used. Try with different credentials."

Is there a reason why the right message cannot be attached in UserValidator->validateIsUnique()? Since it already has an $identify array?

Am I missing anything if I add this? (I will guessing the language files?)

nextpulse commented 9 years ago

A minor side effect of this issue: if both the username and email address already exist, then the above message is displayed twice.

"The credentials provided have already been used. Try with different credentials. The credentials provided have already been used. Try with different credentials. "