Zizaco / confide

Confide is a authentication solution for Laravel 4
1.19k stars 258 forks source link

Laravel 5 Compatibiity #521

Closed impleri closed 9 years ago

impleri commented 9 years ago

Laravel 5 has a few breaking changes (namely RemindableInterface is replaced by Authenticable interface) and a new interface for the main Application. I've updated tests and code to match these two changes, as well as composer dependencies on just 5.x. I also added the last few tests needed to get full code coverage (though that may be more a byproduct of my futzing with everything else).

coveralls commented 9 years ago

Coverage Status

Coverage increased (+1.43%) to 99.76% when pulling e2deb27558c91facc0dadb29d75e07d5ab5f4734 on impleri:master into f9c3d09f68589cc3242a3527464bb871d9815a0f on Zizaco:master.

impleri commented 9 years ago

Touching #448 .

coveralls commented 9 years ago

Coverage Status

Coverage increased (+1.43%) to 99.77% when pulling 99f417f229989c1f470b368ae5ffede0cdeb37be on impleri:master into f9c3d09f68589cc3242a3527464bb871d9815a0f on Zizaco:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+1.43%) to 99.77% when pulling 310f7c623cf6016b3f236b718002265c41bf7420 on impleri:master into f9c3d09f68589cc3242a3527464bb871d9815a0f on Zizaco:master.

ClaraLeigh commented 9 years ago

This is working great for me :+1: Can we get this pulled into the main git repository please? At least into a laravel-5 branch

andrewelkins commented 9 years ago

Yeah I'll get it merged in to the L5 branch shortly. Need to do that from the command line, so it'll have to wait till tonight.

od3n commented 9 years ago

+1

xtrasmal commented 9 years ago

hello party animals. It has been a while... how is it hanging?

Ye-Ting commented 9 years ago

+1

daniel-huang commented 9 years ago

+1 ping @andrewelkins

ghost commented 9 years ago

and...

dcrawkstar commented 9 years ago

Any word on getting to that command line? Would enjoy seeing this support for L5

impleri commented 9 years ago

Authenticable was a typo.

Documentation updated to refer to Contracts namespace.

impleri commented 9 years ago

Leaving version as ~5.0, though, because that is pretty standard version handling in semver. Until Laravel documents its versioning schema, I default to semver.