search

Zizzamia / perfume.js

Web performance library for measuring all performance vitals metrics
https://zizzamia.github.io/perfume/
MIT License
3.13k stars 112 forks source link

web-vitals navigationType support #209

Closed SuperOleg39 closed 1 year ago

SuperOleg39 commented 1 year ago

Looks like we need to send navigationType parameter to analyticsTracker callback.

Any metrics from web-vitals will have this property.

Will try to implement myself first)

Zizzamia commented 1 year ago

Sweet, let me know when the PR is ready and I will review it right away.

SuperOleg39 commented 1 year ago

Added navigationType to all web-vitals metrics - https://github.com/Zizzamia/perfume.js/pull/210/files

Zizzamia commented 1 year ago

Approved, the only thing missing is updating the README, and than we can publish it. I am happy to update the README if you want, or I leave the honor to you.

SuperOleg39 commented 1 year ago

It will be enough? https://github.com/Zizzamia/perfume.js/pull/211

Zizzamia commented 1 year ago

Published to https://github.com/Zizzamia/perfume.js/releases/tag/v8.3.0