Zizzamia / perfume.js

Web performance library for measuring all performance vitals metrics
https://zizzamia.github.io/perfume/
MIT License
3.12k stars 109 forks source link

Cannot read properties of undefined (reading 'requestStart') on navigation with bfcache #220

Closed meskill closed 5 months ago

meskill commented 1 year ago

I'm getting the error from the title on this line when testing bfcache in chrome browser.

Reproduction

  1. Open Chrome DevTools -> Application -> Back/Forward Cache
  2. Click Test Back/Forward cache

image

SuperOleg39 commented 1 year ago

Initial problem from web-vitals package - https://github.com/GoogleChrome/web-vitals/issues/313

SuperOleg39 commented 1 year ago

Following the discussion in web-vitals repo, we can still report 0 values and add just fix for BFCache case - https://github.com/Zizzamia/perfume.js/pull/221

scamden commented 6 months ago

i believe we are hitting this error as well fwiw

undefined is not an object (evaluating 'e.entries[0].requestStart')
Zizzamia commented 6 months ago

@scamden what version are you using?

scamden commented 5 months ago

8.4.0, should i try an upgrade?

scamden commented 5 months ago

I'm upgrading to 9.4 and will let you know if we see again

Zizzamia commented 5 months ago

Also, curios, what version of web-vitals are you resolving, maybe we need to upgrade from Perfume side as well.

scamden commented 5 months ago

Also, curios, what version of web-vitals are you resolving, maybe we need to upgrade from Perfume side as well.

@Zizzamia we have 3.5.2 for web vitals

scamden commented 5 months ago

prior to the upgrade 3.4.0 fwiw

Zizzamia commented 5 months ago

@scamden do you still see the issue after upgrade?

scamden commented 5 months ago

Haven't seen it since to my knowledge (although we had only seen it once so sample size is pretty low for this data :P )

Thanks for the tip on upgrading! Perfume is a great package :)

Zizzamia commented 5 months ago

Ok, so I think it's safe to close this for now.

I will reopen this if this issue happens again.