search

Zizzamia / perfume.js

Web performance library for measuring all performance vitals metrics
https://zizzamia.github.io/perfume/
MIT License
3.12k stars 109 forks source link

Chore - rename 'incrementUjNavigation' to 'trackUJNavigation' #235

Closed lkuangPR closed 1 year ago

lkuangPR commented 1 year ago

Remove enabledNavigationTracking as an init option and always use navigation tracking. Renamed the incrementUjNavigation to trackUJNavigation for clarity. Update readme to reflect the changes

Zizzamia commented 1 year ago

Why advancedUJStep is more clear? What's the thinking behind.

My personal bias when I read advanced is more some sort of hard challenge, like an Advance Class.

Even when I google the word, I am not quite sure how it maps with the functionality we have.

Screen Shot 2023-07-07 at 10 48 23 AM
lkuangPR commented 1 year ago

Mistyped, it should be advanceUJStep, not advancedUJStep advance meaning 'move forward'. I think 'increment' relates more to mathematics adding, so I think advance fits more here.

Zizzamia commented 1 year ago

Niiice! I love how we are thinking around making the API simpler to use.