search

Zloy / backuppc_on_nginx

Nginx config to host BackupPC frontend
22 stars 7 forks source link

merged vhost configs, resolved alias/root bug, moved backuppc to doma… #7

Closed lukas2511 closed 8 years ago

lukas2511 commented 8 years ago

…in root, removed settings that shouldn't be defined as part of a vhost, added section headers in config to make things clear

Zloy commented 8 years ago

Sorry for late answer, I was on a vacation. I cannot merge that, because you've completely removed insecure config. You'd blamed previously the particular line. Why not just fix it?

lukas2511 commented 8 years ago

If you look at the changes you'll see that i merged the two vhosts into one, because it's not necessary to keep two

Zloy commented 8 years ago

Merging these two configs makes things hard to read and maintain. If you like to fix the bug, please do just that.

lukas2511 commented 8 years ago

I personally think it makes things easier to maintain as you don't have to maintain two configs, but if you don't like it then just close this and we'll just forget about it

Zloy commented 8 years ago

Thank you for drawing my attention to root/alias lines. I'll try to fix that on my own. Thank you and good luck!