search

Zn2O / gwt-google-apis

Automatically exported from code.google.com/p/gwt-google-apis
0 stars 0 forks source link

Does Marker class have to be final? #141

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Found in Release:
r290

Detailed description:

Reported by: monfouquoi

A user wants to add extra properties to a Marker so that when a
MarkerClickEvent fires, it is easy to get at information that was available
when the Marker was created (say, to add to an info window).

Currently the Marker class is final, so you can't subclass it. The Overlay
methods it inherits are exported, so we have to be very careful about
overriding them, but those are overridden with final methods in
ConcreteOverlay, so we should be O.K. to remove the 'final' restriction.

Workaround if you have one:

You could create a look-aside HashMap to store your extra data, using the
LatLng coordinates for the markers as a key value.

Links to the relevant GWT Public Forum:
 http://groups.google.com/group/Google-Web-Toolkit/browse_thread/thread/0e834d0149531ba5#

Original issue reported on code.google.com by galgwt.reviews@gmail.com on 19 Jun 2008 at 2:45

GoogleCodeExporter commented 9 years ago 
Removed the final modifier from Marker and added and a unit test with a 
subclass.

Original comment by galgwt.reviews@gmail.com on 19 Jun 2008 at 8:55

Attachments:

GoogleCodeExporter commented 9 years ago 
Committed as r345.

Original comment by galgwt.reviews@gmail.com on 20 Jun 2008 at 2:29

GoogleCodeExporter commented 9 years ago

Original comment by galgwt.reviews@gmail.com on 13 Oct 2008 at 8:54

GoogleCodeExporter commented 9 years ago

Original comment by galgwt.reviews@gmail.com on 11 Dec 2008 at 3:08

GoogleCodeExporter commented 9 years ago

Original comment by zundel@google.com on 21 Dec 2009 at 1:57