search

Znote / ZnoteAAC

Developement repository for the Znote AAC project. A website portal to represent and manage your Open Tibia server.
MIT License
146 stars 127 forks source link

Accounts table doesn't contains "name" #355

Closed Kuhicop closed 4 years ago

Kuhicop commented 5 years ago

Hello, I'm trying to run my TFS 1.2 protocol 7.4 with ZnoteAAC.

The game is working perfectly, I can join the server and play like a charm, but the website have a lot of problems because the database table columns are not as expected.

The main problem here and I hope I don't find more in a future, is that accounts are searched by name in website, and ingame are searched by id.

Znote commented 5 years ago

TFS 1.2 normally has accounts.name column, why doesn't yours? I presume it has been stripped away, which is a bad decision since accounts.name can be used, and can also store account number.

A TFS 1.x protocol downgrade should distinguish between account id and account name(number).

Now its not a clean protocol downgrade of the TFS 1.2 engine, but a rewrite/restructure of the database, which makes it incompatible with the TFS 1.x server engine database structure, and thus Znote AAC or any website configured for TFS 1.x.

You could try to change serverEngine in config.php to OTHIRE, as it does not use the accounts.name column. But unless your actually using OTHire, chances are there will be other database compatibility issues.

If your using nostalrius, #343 We are working on implementing compatibility for it under TFS_10 server engine. I presume this will also be fixed then. Developers seem to like to do uneccesary changes to the db structure. :/

Kuhicop commented 5 years ago

Hello Znote, first of all I want to say thank you for your years of contribution at Tibia. You're one of the best known contributors. Yes I'm trying with the source version of nostalrius (the distribution where Nostalrius started) And yea, it's really hard to understand why people is trying to reinvent the wheel. There's any ETA for this changes?

Znote commented 5 years ago

No ETA, my best guess is within a month or two. There is an unofficial modification of Znote AAC you could try to use if you need it asap: https://otland.net/threads/znote-change-name-to-id.262497/#post-2538850 Although I don't officialy support or maintain that version, use at own risk.

Kuhicop commented 5 years ago

Please, don't close this issue, I will test in few hours to integrate the actual iologindata code with the old one, I'm desktop software developer. If you can hold this issue open until tomorrow I will try my best to help others... thank you :)

Kuhicop commented 5 years ago

I just changed the iologindata.cpp for the original forgotten iologindata.cpp and login to account worked, but I wasn't able to retrieve the character list. And the "unnoficial fix" is giving trouble, I will wait for the official update of Znote, thanks for your time