Closed EPuncker closed 4 years ago
Looks good, I am a bit worried that the new function names for SQL querying in the various znoteshop.lua scripts won't be compatible with older TFS 1.x versions. What engines have you tested it with? If OTX/OtservBR scripts are starting to vary too much from TFS 1.x scripts, we might need to consider a LUA/otservbr-TFS13 folder for those type of scripts.
Looks good, I am a bit worried that the new function names for SQL querying in the various znoteshop.lua scripts won't be compatible with older TFS 1.x versions. What engines have you tested it with? If OTX/OtservBR scripts are starting to vary too much from TFS 1.x scripts, we might need to consider a LUA/otservbr-TFS13 folder for those type of scripts.
don't worry, nothing critical has been changed, the only things I remember are (cid) to (player) and the result.getXXX things, these can be easily fixed by using a newer compat.lua file, and about the otservBR thing, in this PR the only thing I made related to them was the town list ID, everything else was aimed to tfs master and tested on it, but as I took a look at their code, their script are still very similar to tfs master so there is still no need to do a new folder for it
and about the script changes it will only affect 1.0 and 1.1 users that still passes cid but I don't really think there are enough people using these engines to be a problem for us
small fixes and changes everywhere
these deserve a note tho:
if there is anything wrong or missing just tell me and I'll try to fix it