Znote / ZnoteAAC

Developement repository for the Znote AAC project. A website portal to represent and manage your Open Tibia server.
MIT License
145 stars 127 forks source link

login 12.20+/12.30 using email instead of username #424

Closed Bipbop69 closed 4 years ago

Bipbop69 commented 4 years ago

does your login work for customers using email and password? tested on some it didn't work

Znote commented 4 years ago

Where can I download this client to test, and are you using latest otservbr-global/develop server? (or link to the one you use)

The client I currently got doesn't seem to have email login: image

Bipbop69 commented 4 years ago

https://mega.nz/file/7ip32B5T#uHrJwJWiMu6fLNtNqPHDdMdt2P8BUwmWMnCqYZnjIDg Cliente 12.20

pulls https://github.com/opentibiabr/otservbr-global/pull/1381 https://github.com/opentibiabr/otservbr-global/pull/1380 https://github.com/FakeShinoda/otservbr-global/pull/3

or 12.40 ! https://github.com/SaiyansKing/optimized_forgottenserver/commits/master

jlcvp commented 4 years ago

I've done a MyAac plugin, you can use it as a base to get the JSON structure needed

https://github.com/OTG-Developers/myaac-tibia12-login

Znote commented 4 years ago

Works now. :)

image

But I'm still missig 12.40 client to test. Client 12.20 seems to crash on OTG server.

I also see a potential problem: Protocol 12.20 by FakeShinoda uses sessionKey Email, while OTG and SaiyansKing use sessionKey username. We need to agree on a consistent standard for authenticating user that connects to gameworld.

For now I have added email sessionkey, because otservbr with 12.20 PR was the only thing that actually compiled and worked properly with my client. (OTG crashes my client, SaiyansKing didnt compile on Linux).

So currently, 12.20 only works with: https://github.com/opentibiabr/otservbr-global/pull/1396