search

Zod- / jsVideoUrlParser

A javascript parser to extract informations like provider, channel, id, start time from YouTube, Vimeo, Dailymotion, Twitch,... urls
MIT License
234 stars 73 forks source link

Vimeo Live Stream Events shouldn't parse as videos #72

Open rickpern opened 3 years ago

rickpern commented 3 years ago

https://vimeo.com/event/59209 shouldn't be parsed as the normal vimeo video https://vimeo.com/59209

Zod- commented 3 years ago

Can these be embedded?

rickpern commented 3 years ago

Can these be embedded?

Yep, the following would be the embed code for a live stream:

<div style="padding:56.25% 0 0 0;position:relative;"><iframe src="https://vimeo.com/event/59209/embed" frameborder="0" allow="autoplay; fullscreen" allowfullscreen style="position:absolute;top:0;left:0;width:100%;height:100%;"></iframe></div>

Regardless of whether or not they can be embedded, I was just pointing out that when parsing Vimeo video URLs, https://vimeo.com/event/123456 and https://vimeo.com/123456 are very different. One is a live stream and the other is a completely unrelated Vimeo video. So when parsing a Vimeo video, I would suggest parsing https://vimeo.com/event/123456 as a stream and https://vimeo.com/123456 as a video.

Thanks for this library, it's great!

Benimation commented 11 months ago

I came across this issue today, but solved it by making an exception for Vimeo URLs that contain the /event/ part, and manually turning them into their embed URL counterpart.

Would be nice if this could be supported out-of-the-box! :)