Fix error in type declaration

Zod- / jsVideoUrlParser

A javascript parser to extract informations like provider, channel, id, start time from YouTube, Vimeo, Dailymotion, Twitch,... urls

MIT License

235 stars 73 forks source link

Fix error in type declaration #93

Closed murraco closed 2 years ago

murraco commented 2 years ago

Description

Typescript compiler couldn't find the ./provider/template module in js-video-url-parser/lib/index.d.ts:9:15 due to the template files being ignored by NPM.

Issue

https://github.com/Zod-/jsVideoUrlParser/issues/71

Proposed changes:

Bump project version in package-lock.json from 0.4.1 to 0.4.3
Remove ignored templates from .npmignore

Zod- commented 2 years ago

The templates shouldn't go in anyway. I guess #71 would be the better fix?

murraco commented 2 years ago

@Zod- Nice, that works too!

murraco commented 2 years ago

You still might want to update/bump the project version in package.json and package-lock.json and re-build it so NPM catches it.

Zod- commented 2 years ago

You still might want to update/bump the project version in package.json and package-lock.json adn re-build it so NPM catches it.

Working on it