search

Zodsmar / SeedSearcherStandaloneTool

Minecraft, searching numeric seeds for specific features/biomes
GNU General Public License v3.0
311 stars 64 forks source link

"Set Seeds" option disables the ability to use more than 1 core #130

Closed RavingPlatypi closed 3 months ago

RavingPlatypi commented 2 years ago

Hi! Not sure if this issue has been brought up but I find that whenever I search through set seeds I cannot change how many cores the program uses. I also cannot change the spawn point, but I saw in other closed issues that a full rewrite for 1.18 will fix that issue, so I am not too concerned.

For 1.18 I will be selecting a seed and my workflow is going to be as follows:

  1. Generate 10000 seeds with all biome sets within 3k of spawn (0, 0).
  2. Of those seeds, find which ones contain 2 woodland mansions, 20 witch huts, and 30 ocean monuments. Biomes/biome sets will not be specified.
  3. Of those seeds, find which ones have 0 0 NOT be an ocean, icy biome, or jungle.

I'm not sure if this will work if searching through set seeds is this slow. Also, I know you haven't updated to 1.18 yet; I am just testing out this workflow on 1.17 so I am prepared to do it when 1.18 comes around.

Here is what I have selected for the "Data" page when I am on step 2 of my workflow:


Search radius: 7000
Incrementer: 50 (btw "Incrementer" is misspelled. The proper spelling is "Incrementor")
Biome Precision: 16

Then only "Set Seeds" is selected with the correct .txt file.```
Zodsmar commented 2 years ago

Yeah so what you want to do will work in 1.18. Set Seed searching should also be quite a bit faster in 1.18. Ill leave this open till I finish the rewrite as I will pretty much test all of these steps to make sure the flow is possible. Thanks!

RavingPlatypi commented 2 years ago

Ok cool! Thank you so much.

Just to be clear: is the inability to use more than 1 core for set seeds an intended feature or is it a bug that will be fixed in the rewrite?

Zodsmar commented 2 years ago

Kinda both. So because of how coupled and honestly how bad I wrote the code it was something I couldn't implement without a full rewrite. So I made the choice to lock it out. But since Im re writing it now, a lot of those issues are being resolved. I am making the flow of the app modular so I can do stuff like that.

RavingPlatypi commented 2 years ago

Gotcha! Sounds good dude. Thanks a lot. Very excited for the 1.18 rewrite :)

RavingPlatypi commented 2 years ago

I would also like to add that searching for biomes near spawn was SUPER FAST but searching for structures was incredibly slow. This was both with set seeds. Just thought I'd let you know in case it helps!