search

ZoeBijl / font-awesome

AT test for Font-Awesome
MIT License
10 stars 2 forks source link

Fix HTML validation, character entities, and typos #23

Closed mitchellevan closed 8 years ago

mitchellevan commented 8 years ago

Fix HTML validation: matching opening and closing tags. Fix character entities: em dashes and quotation marks. Fix minor typos.

ZoeBijl commented 8 years ago

Before I accept this, why are all quotes turned into dumb-quotes? It's a UTF-8 document, should do smart quotes, dashes, etc just fine. The messed up end tags are the only thing that the nu validator throws at me.

StommePoes commented 8 years ago

I personally like "dumb" quotes, when I do smart quotes I do them as HTML entities: 8220 and 8221 respectively. Smart quotes have traditionally been the harbinger of Zalgo and Windows-users destroying whole docs.

That said, my system didn't have any issues with the "smart" quotes, they were displayed in the only way my fonts can: as dumb (and not into weird nasty smart-quote stuff), so they must've been ok. Searching for something I can't physically type is a pain, though.

I also approve of the mdash/8212, but like above, that's a personal preference.

Or Michiel, this being open-sores, we could just out-vote you : P

Though it honestly doesn't matter to me since my system didn't complain about the quotes. Count me neutral.

ZoeBijl commented 8 years ago

It was more a question than criticisms.

ZoeBijl commented 8 years ago

I've added pretty quotes via CSS now, muwhahaha: https://github.com/MichielBijl/font-awesome/commit/f70c25b0677502556cf177706ffce560227ee470