search

ZoeyR / rls-vs2017

Rust extension for Visual Studio 2017 with RLS support
MIT License
110 stars 12 forks source link

Install component does not work #15

Open TrianglesPCT opened 5 years ago

TrianglesPCT commented 5 years ago

I was going to try this out, but it refuses to install--

I had rust nightly so after reading the other messages here I switched to stable(by making it the default with rustup).

Same result as before. It brings up the Install button. I click it. It says: could no install one of the required rls components

vs2017 15.9.6

ZoeyR commented 5 years ago

Interesting, I'll look into it. This might be due to the renaming of rls-preview to rls.

ZoeyR commented 5 years ago

I just pushed an update that should have fixed this. Would you mind downloading the latest version (0.4.6) and testing?

TrianglesPCT commented 5 years ago

I grabbed the update, but it still does the same thing

Is there a log file that maybe shows more info about what is going wrong?

bugproof commented 5 years ago

I have the same issue

mmttim commented 5 years ago

I have the issue as well.

Visual Studio 2017 15.9.7 with the latest plugin from the marketplace.

I started Visual Studio with admin rights, no change.

ghost commented 5 years ago

I'm guessing this has something to do with it. untitled

ZoeyR commented 5 years ago

@v3Monsta unless they changed rustup that shouldn't actually be the issue. installing rls-preview still works from my testing but in newer versions of Rust the module is reported at "rls". When I get home tonight I'll test it just to make sure.

Jaggernaut555 commented 5 years ago

It could also be caused by the installed Nightly build missing the RLS component as described here. Perhaps more verbose errors on attemping to install the components could help with this.

ghost commented 5 years ago

That seems far more likely than my guess and I'll see if downgrading to a build of nightly that includes the RLS fixes my issue. However, while the current rustup does autocorrect rls-preview to rls, it might still be worth changing to avoid breaking if rustup changes in the future.

Edit: Doesn't look like it's because the RLS is missing from nightly. I installed nightly-2019-02-27 and the extension is still having a hard time.

MaulingMonkey commented 5 years ago

The extension by default explicitly tries to use nightly, so you'd need to change that under Tools > Options > Rust. Of course, that dialog was broken for me in VS 2017 15.9.12, possibly due to a VS bug or breaking change - I've created a PR to fix that: https://github.com/dgriffen/rls-vs2017/pull/24

I've been switching to stable and that seems to work.

mouse07410 commented 5 years ago

I've been switching to stable and that seems to work.

Not for me:

Screen Shot 2019-06-17 at 1 24 57 PM Screen Shot 2019-06-17 at 1 30 32 PM
ZoeyR commented 5 years ago

@mouse07410 what happens if you run rustup component add rls --toolchain stable manually?

mouse07410 commented 5 years ago
Screen Shot 2019-06-17 at 1 47 43 PM

And then the same thing/problem/error in the VS2017.

Update

Note, that on Windows it happens with both VS2017 and VS Code. On other patforms, VS2017 is not viable at all, but VSCode works perfectly. Everything gets installed, everything works. So, it seems to be Windows-related.

ZoeyR commented 5 years ago

@mouse07410 that is very strange, if it happens in VS Code as well it may be better to file a bug there since they have more resources to triage the bug and I can then look into what their fix was.

mouse07410 commented 5 years ago

Let me double-check the VSCode.