search

ZohoDevelopers / embeddedApp-js-sdk

Js SDK for Zoho Embeded app
Apache License 2.0
48 stars 27 forks source link

Sleep is dangerous #15

Closed BartTactick closed 3 months ago

BartTactick commented 3 years ago

https://github.com/ZohoDevelopers/embeddedApp-js-sdk/blob/e45784d201465c12f1fc10a575daab30ca44d91a/lib/ZSDK.js#L56 I dont know if this function is being used anywhere but this code can freeze up someone`s browser. Please use something along the lines of: await new Promise((res) => setTimeout(res,timeout_here))

aadhil-kh-9161 commented 3 months ago

Thanks for reporting the issue in code. It is currently unused and will be eventually removed in our upcoming major SDK release.