The Fremennik Isles - ore requirements

[zile13579]

Wiki states: " Either 8 tin ores, 7 pieces of coal, or 6 mithril ores (depends on your Mining level; levels 1-9 will require tin ore, 10-54 will require coal, and 55-99 require mithril ore). Note: The ores can be noted."

RuneLite plugin makes no mention of this, and just says "8x Tin ore".

Also does not mention ores can be noted, but it should.

[kcjg94]

        if (client.getRealSkillLevel(Skill.MINING) >= 55)
        {
            ores = new ItemRequirement("Mithril ore", ItemID.MITHRIL_ORE, 6);
        }
        else if (client.getRealSkillLevel(Skill.MINING) >= 10)
        {
            ores = new ItemRequirement("Coal", ItemID.COAL, 7);
        }
        else
        {
            ores = new ItemRequirement("Tin ore", ItemID.TIN_ORE, 8);
        }

The plugin is checking the user's mining level and suggesting items based on said mining level, which lines up with what the wiki says.

https://github.com/Zoinkwiz/quest-helper/blob/master/src/main/java/com/questhelper/helpers/quests/thefremennikisles/TheFremennikIsles.java#L308C1-L319C4

[zile13579]

Odd, I have mining 93, and the plugin told me to bring tin. Must be an one off error.

[kcjg94]

It does seem broken actually.

[kcjg94]

I tried Throne of Miscellania which is another quest that has a dynamic skill suggestion in its setupRequirements() and it also doesn't work correctly, it should suggest a rake since I have 10 farming but it does not.

The skill level when setupRequirements() is called here is 0 - which explains why dynamic skill requirements aren't working. That client info may not be set at that point in time. Maybe it worked in the past and isn't now due to some race condition.

[pajlada]

Confirmed this is a bug, and your reasoning is correct @kcjg94 Will be fixed by https://github.com/Zoinkwiz/quest-helper/pull/1643