search

Zoinkwiz / quest-helper

Helps with Quests.
BSD 2-Clause "Simplified" License
235 stars 408 forks source link

lumbridge & draynor elite diary should be filtered by all quest requirements #1737

Open tovc opened 1 month ago

tovc commented 1 month ago

currently, the lumbridge & draynor elite diary is not filtered by skills such as defense, despite those skills being required for the quest cape, and subsequently the diary itself

kcjg94 commented 1 month ago

The method to check all quests here isn't a QuestRequirement in the getGeneralRequirements() call. Meaning it won't enter the stream here as a quest requirement.

I don't see a good fix for this, cause adding all the quests as a requirement to the diary isn't ideal - and adding logic for specific quests to the skill filtering config is also not ideal.

tovc commented 1 month ago

I'll be perfectly honest with you, that's gone in one ear, out the other. I'm a user, not a developer. I don't have a proposal for a neat fix.

Zoinkwiz commented 1 week ago

https://github.com/Zoinkwiz/quest-helper/commit/d46bb21735b62148b5ba3d7cdf25f5b2279ffe7f should make this check its own implementation of a Requirement, which means we can potentially handle a version of this base new requirement to be considered for pass checks. Not fixed yet, but worth considering when this is looked at for fixing.