Previously, when a quest was shut down, we did not reset the lastStep variable in QuestManager
The lastStep variable is used to check if the highlight in the quest helper's side panel should change, and if we don't reset it, then stop & start the same quest, we'll have an active but unhighlighted step.
This PR prevents this.
The first commit consolidates all public QuestManager "shut down quest" functions into a single one to ensure I don't have to copy paste the lastStep logic elsewhere. It would be good to take an extra look at this to ensure I have missed anything where maybe the background helper should actually remain closed if a quest is shut down in a special way. I tested this to the best of my ability (starting/stopping the "Check all items" quest & other quests, while toggling the "Highlight all items" option on and off) and everything seems to work as expected.
Previously, when a quest was shut down, we did not reset the
lastStepvariable inQuestManagerThe
lastStepvariable is used to check if the highlight in the quest helper's side panel should change, and if we don't reset it, then stop & start the same quest, we'll have an active but unhighlighted step. This PR prevents this.The first commit consolidates all public
QuestManager"shut down quest" functions into a single one to ensure I don't have to copy paste thelastSteplogic elsewhere. It would be good to take an extra look at this to ensure I have missed anything where maybe the background helper should actually remain closed if a quest is shut down in a special way. I tested this to the best of my ability (starting/stopping the "Check all items" quest & other quests, while toggling the "Highlight all items" option on and off) and everything seems to work as expected.