Zokonius / planar-artifice

The Planar Artifice addon for Thaumcraft 6.
MIT License
7 stars 10 forks source link

Build Might be Broken #11

Closed TheCodex6824 closed 2 years ago

TheCodex6824 commented 2 years ago

I was testing the mod in dev to help someone figure out why the research wasn't appearing (it does work as of the latest commit but does not on the current release), and there were a few issues that popped up when trying to build the mod at all:

  1. There are a few dependency issues - the Soot entry needs to be updated to use the new curse maven format, and Bewitchment seems to be gone from whatever maven repo it was in before (switching it to curse maven worked fine). It would also be convenient to add in Embers as a runtime dependency, since Soot requires it.
  2. Even after fixing that, whenever I tried to compile the mod, the compiler was not finding any of the dependencies. (No longer the case - see edit)
  3. Lastly, I noticed you are using ForgeGradle 3.0, which means that even if it did work for me, there would be some issues like mod resources not working. There are apparently some workarounds, but I'm not familiar enough with them to recommend one.

I'm not quite sure whether item 2 is the build actually being broken or my setup having issues because I do most of my modding with ForgeGradle 2.3, which is why I am outlining these things in an issue instead of just opening a PR immediately. I probably will make a PR addressing just the missing / broken deps and leave the other items to people that are more familiar with the newer toolchains.

Edit: Thaumcraft needed to be deobfuscated. Eclipse still doesn't run, but the mod at least builds on the command line now.