search

Zokrates / ZoKrates

A toolbox for zkSNARKs on Ethereum
https://zokrates.github.io
GNU Lesser General Public License v3.0
1.8k stars 360 forks source link

wrong feature coverage in zokrates_ast #1365

Closed brew0722 closed 4 months ago

brew0722 commented 5 months ago

The flat_expression_from_variable_summands function is also used within the snark_verify_bls12_377 function implemented with the ark feature. https://github.com/Zokrates/ZoKrates/blob/f10293338160eee2209e62f536bea8f095ce38dd/zokrates_ast/src/common/embed.rs#L499

https://github.com/Zokrates/ZoKrates/blob/f10293338160eee2209e62f536bea8f095ce38dd/zokrates_ast/src/common/embed.rs#L26 However, since the use expression is tied to the bellman feature, a compilation error occurs if only the ark feature is activated.

dark64 commented 5 months ago

Nice catch 😅 Thanks @brew0722

brew0722 commented 5 months ago

@dark64 Thanks for your quick confirmation 👍 , I'll be waiting.