Zolkin1 / torc

TORC: Tools for Optimization, Robotics, and Control
1 stars 1 forks source link

Finished BaseCost and LinearCost classes with tests. #2

Closed gavin-hyl closed 6 months ago

gavin-hyl commented 6 months ago
Zolkin1 commented 6 months ago

@gavin-hyl it's looking good. I made some changes. Please pull the new code and make sure it runs/that you are ok with all the changes. when you are good with the changes I'll merge it in!

gavin-hyl commented 6 months ago

Just pulled. My catch2 setup had some minor problems, but its all fixed now.

Zolkin1 commented 6 months ago

Looks like you removed the linear_cost.cpp file, which is fine, but I get a Cmake error saying I can't find that file when I try to run the tests because it is still being referenced in the Cmake file in the costs folder. Do you get the same error?

gavin-hyl commented 6 months ago

Apologies for not checking last time. I removed the file from the cmake and specified the target language, should be able to run now.