search

Zomboided / service.vpn.manager

VPN plugin for Kodi
GNU General Public License v2.0
316 stars 80 forks source link

NordVPN stopped working #393

Closed Arathonk closed 1 year ago

Arathonk commented 1 year ago

Since today NordVPN stopped working, I reinstalled and correctly filled in my login, but its giving me an message saying it can't connect. Logfile: https://paste.kodi.tv/uqopeqagad

mikfrase commented 1 year ago

Looking forward in applying & testing this update on Matrix 19.5

quickstang commented 1 year ago

Not sure what NordVPN have done but it also broke for me. I did find a quick work around though. Reset all the OpenVPN settings (or just uninstall and reinstall) and use the UserDefined settings. Download a couple of .ovpn config files from NordVpn https://nordvpn.com/ovpn/ and also find your Service Credentials for manual setup. These are located on your dashboard page after you select the 'NordVPN' service. The Username and Password generated here will now be your login details for OpenVPN. You will need to import the .ovpn config files through the OpenVPN settings wizard for all the servers you have. Note that they will probably change over time so I'm not sure how stable this will be going forward.

It looks like Nord allow your original Un and Pwd to log into any of the official NordVPN apps, but any third-party VPN client may have to use the alternative service credentials.

I got this method to work. I didn't have to change my username and password. All I did was use userdefined, downloaded a handful of .ovpn files, used filezilla to copy them in a new directory and loaded them in the add-on. Checked VPN status and it shows I'm connected.

I didn't have to use any service credentials. At least not at the moment.

peno64 commented 1 year ago

The changes are on https://github.com/peno64/service.vpn.manager so until the PR is accepted you could install the zip from there.

FatFreddysDog commented 1 year ago

Brilliant you are a legend. Thanks

Zomboided commented 1 year ago

@peno64 Can you test https://github.com/Zomboided/service.vpn.manager/releases/tag/7.0.2 and I'll push it out on the repository. They're your changes, plus some tracing.

BrodjagaRatnik commented 1 year ago

https://github.com/Zomboided/service.vpn.manager/releases/tag/7.0.2 works Ty.

BrodjagaRatnik commented 1 year ago

Typo in changelog.txt v7.0.1 must be v7.0.2

v7.0.1

  • Changes to NordVPN to allow to login with token instead of user name/password because of api change at NordVPN

v7.0.1

  • ...
kpisacic commented 1 year ago

@Zomboided , @peno64 - works also for me, many thnx!

Zomboided commented 1 year ago

ok, fixed the changelog (in github, for the next release) and pushed the change to the repo....thanks @peno64

Zomboided commented 1 year ago

Anyone that switched to user defined to steal TV might want to switch back to using the native support...up to you

peno64 commented 1 year ago

@Zomboided I installed your released version and all is ok. Maybe it's a good idea to pin this issue such that users find it before they create a new defect and also to see the instructions I wrote how to obtain the token.

Arathonk commented 1 year ago

Freshly installed 7.0.2 but its not working for me, neither with the wizard or via settings, I get "Please enter a user name and password. NordVPN requires them for authentication."

peno64 commented 1 year ago

Are you sure you entered the correct token? How did you enter it? via copy/paste or enter it manually? And its the token from the nordvpn webpage you entered?

Arathonk commented 1 year ago

Are you sure you entered the correct token? How did you enter it? via copy/paste or enter it manually? And its the token from the nordvpn webpage you entered?

Yes I copy/pasted it from the Nordvpn dashboard.

peno64 commented 1 year ago

Does the setup page looks a bit like this:

image

And the token is quite long? here it's 64 characters long.

Arathonk commented 1 year ago

Does the setup page looks a bit like this:

image

And the token is quite long? here it's 64 characters long.

Yes it does look like that.

Zomboided commented 1 year ago

@peno64 This happens as soon as you validate a connection. I bet there's some code in there to check to see whether that's a userID/password. There's probably code like that in multiple places. You probably avoided it by editting your settings.xml which is totally not recommended as I abuse the hell out of that file and previously there were problems with settings being wiped out if things got hairy.

On Wed, Apr 5, 2023 at 9:52 PM Arathonk @.***> wrote:

Does the setup page looks a bit like this:

[image: image] https://user-images.githubusercontent.com/32430988/230202815-75294852-2fd5-42e2-aff0-1c88287aff1c.png

And the token is quite long? here it's 64 characters long.

Yes it does look like that.

— Reply to this email directly, view it on GitHub https://github.com/Zomboided/service.vpn.manager/issues/393#issuecomment-1498136520, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECJZZKOIP74HPFE7C3YTMTW7XLPDANCNFSM6AAAAAAWRJYDNA . You are receiving this because you were mentioned.Message ID: @.***>

peno64 commented 1 year ago

@Zomboided I did test it by entering the token via the settings screen and it worked fine. But it could be that the settings file also still contained the user name and password. I will try it with an empty settings file and see what happens.

Zomboided commented 1 year ago

You want to fix line 56 of connect.py to check to see if a token exists if the provider is nord, otherwise check the password/userID as it does today

On Wed, Apr 5, 2023 at 10:00 PM peno64 @.***> wrote:

@Zomboided https://github.com/Zomboided I did test it by entering the token via the settings screen and it worked fine. But it could be that the settings file also still contained the user name and password. I will try it with an empty settings file and see what happens.

— Reply to this email directly, view it on GitHub https://github.com/Zomboided/service.vpn.manager/issues/393#issuecomment-1498151030, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECJZZN7SXMFUVO5C5GRBX3W7XMNTANCNFSM6AAAAAAWRJYDNA . You are receiving this because you were mentioned.Message ID: @.***>

Zomboided commented 1 year ago

Actually, I coded around this occurance already. In vpnproviders.py, add the "NordVPN" string to 'providers_no_pass' array and it'll probably all just work fine. I've committed a change for this in Git, but you'll need to test.

On Wed, Apr 5, 2023 at 10:01 PM Matt Smith @.***> wrote:

You want to fix line 56 of connect.py to check to see if a token exists if the provider is nord, otherwise check the password/userID as it does today

On Wed, Apr 5, 2023 at 10:00 PM peno64 @.***> wrote:

@Zomboided https://github.com/Zomboided I did test it by entering the token via the settings screen and it worked fine. But it could be that the settings file also still contained the user name and password. I will try it with an empty settings file and see what happens.

— Reply to this email directly, view it on GitHub https://github.com/Zomboided/service.vpn.manager/issues/393#issuecomment-1498151030, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECJZZN7SXMFUVO5C5GRBX3W7XMNTANCNFSM6AAAAAAWRJYDNA . You are receiving this because you were mentioned.Message ID: @.***>

peno64 commented 1 year ago

@Zomboided Ok, I will test it

peno64 commented 1 year ago

@Zomboided I removed the settings.xml file, restarted kodi and setup the connection and indeed I also got the message "Please enter a user name and password. NordVPN requires them for authentication."

Then I applied your change and it fixes the problem. I tried both manual settings and wizard starting from an empty settings file. manual settings is fine.

However wizard does not work. At a given moment tit says: "Click ok to create a VPN connection to NordVPN for user name ." That is from common.py line 1280. Maybe also here a test should be added if vpn_povider is NordVPN that it should say something different but probably not show the token. Going further then fails. It says "Could not authenticate with VPN provider. Please check user name and password and try again. The strange thing is that it did not ask for a user rname, password or token in case of wizard. At the beginning of the wizard it does say that it would ask for this during connection but it didn't. Maybe this is because o f your last change?

peno64 commented 1 year ago

@Zomboided

Indeed. If I remove NordVPN from providers_no_pass the wizard setup does ask for a user name now. Which is also not correct.

Still need to do somo work here...

peno64 commented 1 year ago

@Zomboided

Ok I see how I can fix this. Will make a new pull request for this.

peno64 commented 1 year ago

@Zomboided

I created a new pull request. Tried with a removed settings file to setup nordvpn both via settings and via the wizard and all is good with it. It now also asks for a token in the wizard and it doesn't task or show traces of user name or password anymore. At least in the happy flow...

I also tested user defined both via settings and wizard and this also still works.

Sorry for not having tested this more carefully before.

Zomboided commented 1 year ago

I'd forgotten there was a new user wizard! Ok, I've pushed your changes to the repo and there's a release on Github. I've done zero testing because I have no time to spend on this today so I guess we're doing live user testing here!

On Wed, Apr 5, 2023 at 11:52 PM peno64 @.***> wrote:

@Zomboided https://github.com/Zomboided

I created a new pull request. Tried with a removed settings file to setup nordvpn both via settings and via the wizard and all is good with it. It now also asks for a token in the wizard and it doesn't task or show traces of user name or password anymore. At least in the happy flow...

I also tested user defined both via settings and wizard and this also still works.

Sorry for not having tested this more carefully before.

— Reply to this email directly, view it on GitHub https://github.com/Zomboided/service.vpn.manager/issues/393#issuecomment-1498253710, or unsubscribe https://github.com/notifications/unsubscribe-auth/AECJZZP5R773DXQXOM5DXTTW7XZS3ANCNFSM6AAAAAAWRJYDNA . You are receiving this because you were mentioned.Message ID: @.***>

peno64 commented 1 year ago

@Arathonk Can you test it with the new release (7.0.3)? If possible both with wizard and manual configuration via user setting as I see you also tried it yesterday with both and both failed for you. They should now work. Thanks

Arathonk commented 1 year ago

@Arathonk Can you test it with the new release (7.0.3)? If possible both with wizard and manual configuration via user setting as I see you also tried it yesterday with both and both failed for you. They should now work. Thanks

Both work now! Only when you use the manual configuration, after you've put in your token, first press okay, and they try to make a first connection, otherwise you can't make a first connection.

FatFreddysDog commented 1 year ago

@peno64 @Zomboided @kpisacic

Great work many thanks for fixing this.

peno64 commented 1 year ago

Credits must go more to @kpisacic who found out that the token from the NordVPN page can be easily replace the user/password auth and how to implement it.

hub880 commented 1 year ago

Hi. Are there plans to implement the same fix for version 6.3.7 ( kodi leia 18.9 / python2.7)?

peno64 commented 1 year ago

@hub880 Not really. Is it not time to move on with your kodi version. Version 18 is 2 releases behind the current kodi release...

jim-cat commented 1 year ago

Thanks for fixing!

JuliusCaeser2030 commented 1 year ago

Works perfect thanks. Added a token. Connected no problem. Very easy to add profiles for other country servers... Also, I think it's stating the obvious but I had OpenVPN and the NordVPN app but couldn't see the add token option until I installed the repository you are talking about here: https://github.com/Zomboided/repository.zomboided.plugins/releases/tag/1.0.1 Then it works like charm.

fxleblond commented 11 months ago

Hello. I can't connect with NordVPN. I successfully generated the Token, I entered it in the field after selecting NORDVPN from the list. At no time am I asked for a password! And when I launch the first connection, I get an error: "Error reading username from Authfile : /storage/.kodi/addons/service.vpn.manager/NordVPN/pass.txt".

I tried to fill this file, either with the password associated with the Token, or the password associated with my email, and I still get the same error. I wonder what is the exact procedure for setting up NordVPN?

peno64 commented 11 months ago

There must be something wrong with the token. Try to generate a new one and make sure that you check that it doesn't expire. You should only have to enter the token in the settings. If it asks for the password or gives that error then a wrong token was entered.

fxleblond commented 11 months ago

There must be something wrong with the token. Try to generate a new one and make sure that you check that it doesn't expire. You should only have to enter the token in the settings. If it asks for the password or gives that error then a wrong token was entered.

Thank you for your answer. Indeed I tried to generate a new token, and it works, without entering any login or password. Perfect !

CryptoriousBIG commented 9 months ago

Hi folks - I had to reinstall LibreElec on my Raspberry Pi and subsequently had to reinstall OpenVPN as well. In doing so, I am no longer able to log-in and set up my NordVPN account. I know a previous patch had been released to force the NordVPN sign-in details to be a token instead of a username and password combination but don't see this anymore. Is there a new update I should be installing?

peno64 commented 9 months ago

Are you sure you are using the latest version of this addon? When you choose NordVPN provider, it should ask for the token. If not I think you are using a wrong version.

peno64 commented 9 months ago

Do you have a backup of your previous installation? If so and you can retrieve settings.xml from this addon and restore it on your new installation it should work immediately (after a restart of kodi). If not, also try to delete the current settings.xml, restart kodi and try again.

CryptoriousBIG commented 9 months ago

Are you sure you are using the latest version of this addon? When you choose NordVPN provider, it should ask for the token. If not I think you are using a wrong version.

I pushed the .zip for version 7.0.4 to my Raspberry Pi using Putty. I also uninstalled and tried reinstalling OpenVPN by linking the Troypoint repo which has the Zomboided data in it but noted it has an earlier version of OpenVPN. Both ask for a username and password when selecting NordVPN.

CryptoriousBIG commented 9 months ago

Do you have a backup of your previous installation? If so and you can retrieve settings.xml from this addon and restore it on your new installation it should work immediately (after a restart of kodi). If not, also try to delete the current settings.xml, restart kodi and try again.

Unfortunately not as I did a full wipe of my memory card to fix some issues I was having. I'll try wiping settings and restart. Can you confirm if 7.0.4 the latest and greatest for OpenVPN?

peno64 commented 9 months ago

yes 7.0.4 is the latest. can you also check in kodi that 7.0.4 is actually installed.

CryptoriousBIG commented 9 months ago

yes 7.0.4 is the latest. can you also check in kodi that 7.0.4 is actually installed.

Ok, that's the one I'm trying to install. It seems maybe I haven't pathed the file correctly though with Putty. I've only done this a few times in the past so maybe I'm making an error. Here's what I've done so far, following the installation instructions posted in the wiki for the Zomboided OpenVPN:

  1. Pushed the zip file to LibreElec using Putty by typing the following "wget -O service.vpn.manager-7.0.4.zip https://github.com/Zomboided/service.vpn.manager/releases/tag/7.0.4"
  2. Installed the .zip in LibreElec
  3. Attempted to setup OpenVPN using the installation wizard but keep seeing a username and password input request for NordVPN

Upon deleting OpenVPN and trying this process again, the entire system (LibreElec) restarts on me when I attempt to install the .zip and OpenVPN doesn't show up when LibreElec boots back up. Any ideas?

Am I entering the wget line in Putty incorrectly? Apologies if I'm obviously missing something as I'm not an expert in doing this sort of thing quite yet.

peno64 commented 9 months ago

You are not downloading the zip file but a html file with that command. That is also why kodi crashes with it. This is the correct command: wget https://github.com/Zomboided/service.vpn.man ager/releases/download/7.0.4/service.vpn.manager-7.0.4.zip

CryptoriousBIG commented 9 months ago

You are not downloading the zip file but a html file with that command. That is also why kodi crashes with it. This is the correct command: wget https://github.com/Zomboided/service.vpn.man ager/releases/download/7.0.4/service.vpn.manager-7.0.4.zip

Perfect, that did it! Thanks so much for your help!

bam72 commented 1 week ago

I still couldn't get this to work using the Nord profile in the addon with the nord token, but using the User Defined option with downloaded openvpn files from nord and a pass.txt file with my credentials worked first time. I now have 5 nord servers set up and working perfectly with the latest version of KODI. I downloaded a load of server files from nord to my pc then uploaded them all to a folder on my pi and used this folder to import them all into openvpn manager. Its strange as Nord used to work fine with this addon then just stopped working. One thing I did do, which may or may not have been needed was to make a .crt and .key file for each server from the data within the .ovpn file. Oh and I am using the 7.0.4 version from here not the 7.0.3 from the repository.