Using Run -> Step Continue can lead to infinite loop - Githubissues

Zomis / Brainduck

Brainfuck Interpreter in Java/Groovy, with a Groovy DSL

40 stars 1 forks source link

Using Run -> Step Continue can lead to infinite loop #25

Closed Zomis closed 8 years ago

Zomis commented 8 years ago

When using this code: http://codereview.stackexchange.com/q/26648/31562 and pressing F8 (Step Continue) the program can hang, or it can also stop the loop at the wrong place.

The intended behavior, I believe, is:

If you are not inside any loop, then go to next loop if one exists. If no such loop exists, do the same as a single normal step would.
Otherwise, go to the END_WHILE of the loop that you are currently in. And then go one step beyond it (so that it is either the start of the next iteration, or at the loop end)

Zomis commented 8 years ago

The infinite loop was caused by not checking BrainfuckCode.getNextCommand() for null