search

Zomis / FactorioMods

Various mods for the game Factorio
https://mods.factorio.com/mods/zomis
MIT License
15 stars 9 forks source link

Visual Signals display error in Multiplayer #18

Closed judos closed 7 years ago

judos commented 7 years ago

Hi there, In a multiplayer game where I tried the "visual signals" mod of yours I got this error when placing the first signal display: "Error while running event visual-signals::on_tick (ID 0) visual-signals/control.lua:166: attempt to index field 'gui_signal_display' (a nil value)"

I'm player number 2 on that map so maybe it's multiplayer related? Thanks for checking!

Zomis commented 7 years ago

Hmm. Interesting. I must admit that I have never tried this in a multiplayer game (shame on me!). Is it reproducible? Have you gotten the mod to work in a multiplayer game at any time?

I will open up the code and start investigating.

Zomis commented 7 years ago

I see the problem, expect a fix tomorrow! (unfortunately I have to get up really early tomorrow so I gotta go to bed shortly)

judos commented 7 years ago

Cool thanks! I have never used it before in multiplayer. Multiplayer is where the use case also becomes interesting. Maybe players would like to display something for themselves or something for everyone. A lot of possible extensions I see here. But for me right now it would be fine if the display just shows the same for everyone :)

Zomis commented 7 years ago

Updated now. Please let me know if you continue to experience problems!

When placed, it will show for everyone in the force but each player has the possibility to show/hide individual circuit network displays by using the icon at the top.