search

Zondax / filecoin-solidity

Filecoin Solidity API Library
Apache License 2.0
95 stars 43 forks source link

Consider dropping support for `call_actor_id` #242

Closed raulk closed 1 year ago

raulk commented 1 year ago

Every actor has double the amount of methods it should have, as it offers both call_actor (address) and call_actor_id variants. Consider dropping the call_actor_id variants entirely. On the EVM runtime side, call_actor_id simply wraps the ID in an f0 address. Instead, we should offer the user a FilecoinAddress conversion method as part of #241, so that users wanting to call an actor by ActorID can do (pseudocode):

uint64 actorID = 123;
FilecoinAddress idAddr = Addressing.fromActorID(actorID);
MinerAPI.doTheThing(idAddr, ...);

:link: zboto Link

raulk commented 1 year ago

Please check convo in Slack for the latest direction!