More instances of bytes vs id addresses in inputs and Structs

[snissn]

263 for background.

Many of the types / structs being used specify the type of filecoin address variables in bytes. For example: in DataCapAPI.burnFrom DataCapAPI.sol calls by address into DataCapTypes.ActorID -> DataCapTypes.BurnFromMethodNum with params:

   struct BurnFromParams {
        bytes owner;
        BigInt amount;
    }

so a solidity user will need to construct bytes owner. Can this be moved to a filecoin id?

Below is a non exhaustive list of such parameters that can be changed:

MinerAPI.sol

• [x] bytes memory addr

DataCapAPI.sol

• [x] balance(bytes memory addr) internal

MarketAPI.sol

• [x] addBalance(bytes memory provider_or_client
• [x] getBalance(bytes memory addr)

Precompiles.sol

• [x] resolveAddress(bytes memory addr)
• [x] resolveEthAddress(bytes memory addr)
• [x] lookupDelegatedAddress returns (bytes memory)

SendAPI.sol

• [x] send(bytes memory toAddress

types/AccountTypes.sol

• [x] All instances of operator and owner should be filecoin addresses

types/InitTypes.sol

• [x] bytes code_cid should be 20 bytes

• [x] Filecoin addresses: id_address, robust_address, subaddress

types/MarketTypes.sol

• [x] bytes piece_cid, bytes provider_or_client, bytes provider, bytes client,

types/MinerTypes.sol

• [x] bytes owner; bytes proposed; bytes addr, bytes new_worker, bytes amount_requested, bytes amount_withdrawn, bytes new_beneficiary

types/PowerTypes.sol

• [x] bytes owner, bytes worker, bytes peer, bytes id_address, bytes[] multiaddrs, bytes robust_address,

types/VerifRegTypes.sol

• [x] bytes addr

:link: zboto Link

[emmanuelm41]

@snissn this could be something interesting to do if we first create some kind of utility functions to handle filecoin addresses on solidity (check, convert from string to bytes, from bytes to string, etc). Until we don't have something like that, it will be impossible to do it.

[emmanuelm41]

Depends on #241