Within BigNumbers.sol, but outside of the library definition, a BigNumber struct is defined. This makes using the library confusing for developers as they may opt to specifically import the library using the "from" syntax and this excludes the data struct. I.e.
This will error. The same goes for the BigInt library. Creating separate libraries for those structs, placing them within the library or placing them within another type library (such as commontypes) would be great. I am partial to the last option (placing them in a location such as CommonTypes).
@ZakAyesh I like the idea you have. Unfortunately, BigNumbers library is external to the repository. I think I will move BigNumber inside the BigNumbers lib, and BigInt to CommonTypes as you suggested.
Within BigNumbers.sol, but outside of the library definition, a BigNumber struct is defined. This makes using the library confusing for developers as they may opt to specifically import the library using the "from" syntax and this excludes the data struct. I.e.
This will error. The same goes for the BigInt library. Creating separate libraries for those structs, placing them within the library or placing them within another type library (such as commontypes) would be great. I am partial to the last option (placing them in a location such as CommonTypes).
:link: zboto Link