Closed shrenujbansal closed 1 year ago
The DealProposal label type here https://github.com/Zondax/filecoin-solidity/blob/master/contracts/v0.8/types/MarketTypes.sol#L108 does not mirror the type from the protocol mentioned here: https://github.com/filecoin-project/go-state-types/blob/3ee9fb7d0a8254ad98bbdebca7b005f077701dbe/builtin/v10/market/deal.go#L209
This needs to be DealLabel and not string. This also requires the implementation for the DealLabel struct and any associated functionality for it
DealProposal Cbor encode/decode will also change as a result of this here: https://github.com/Zondax/filecoin-solidity/pull/229
:link: zboto Link
The DealProposal label type here https://github.com/Zondax/filecoin-solidity/blob/master/contracts/v0.8/types/MarketTypes.sol#L108 does not mirror the type from the protocol mentioned here: https://github.com/filecoin-project/go-state-types/blob/3ee9fb7d0a8254ad98bbdebca7b005f077701dbe/builtin/v10/market/deal.go#L209
This needs to be DealLabel and not string. This also requires the implementation for the DealLabel struct and any associated functionality for it
DealProposal Cbor encode/decode will also change as a result of this here: https://github.com/Zondax/filecoin-solidity/pull/229
:link: zboto Link