Zondax / filecoin-solidity

Filecoin Solidity API Library
Apache License 2.0
94 stars 43 forks source link

Unvendoring dependencies #322

Closed raulk closed 1 year ago

raulk commented 1 year ago

In #248 I asked to vendor external dependencies to make the codebase easier to follow. Unfortunately this deteriorates the downstream developer experience of this library because it duplicates types.

For example:

  1. My smart contract users OpenZeppelin's BigInts for some reason.
  2. filecoin-solidity has vendored OpenZeppelin's BigInts.
  3. Whenever I interact with filecoin-solidity I need to use the vendored BigInts, but my contract uses the external BigInts and Solidity can't reconcile/cast easily.

Should be a simple thing to undo? I know it adds to the plate, but from my point of view the steps are:

  1. Delete files.
  2. Re-add package.json dependencies.
  3. Probably add the remappings somewhere?

:link: zboto Link