search

Zondax / filecoin-solidity

Filecoin Solidity API Library
Apache License 2.0
94 stars 43 forks source link

Prefer `bytes.concat` over `abi.encodePacked` for concatenation #328

Closed Stebalien closed 1 year ago

Stebalien commented 1 year ago

See https://github.com/ethereum/solidity/issues/10903.

:link: zboto Link

emmanuelm41 commented 1 year ago

@Stebalien there is only one place where we could actually replace this. Other places are not concatenating bytes only. https://github.com/Zondax/filecoin-solidity/blob/d9fded44f38baa403dbf4981a38b062555355da5/contracts/v0.8/utils/FilAddresses.sol#L44

emmanuelm41 commented 1 year ago

Should we change only that place?

Stebalien commented 1 year ago

Ah, because the other places are using non bytes types. I see.

Nah, makes sense. Sorry for the noise.

emmanuelm41 commented 1 year ago

@Stebalien np at all! Thanks for the feedback