search

Zondax / filecoin-solidity

Filecoin Solidity API Library
Apache License 2.0
95 stars 43 forks source link

Fix comment #361

Closed orenyomtov closed 1 year ago

orenyomtov commented 1 year ago

:link: zboto Link

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

rllola commented 1 year ago

Hey @orenyomtov Could give me some more context for this change ?

orenyomtov commented 1 year ago

If I'm not mistaken, the original comment was wrong, so I fixed it

The precompile by default calls the actor, and does not delegate call it

rllola commented 1 year ago

We do use delegated call opcode for it so we are doing a delegated call like the comment originally mentioned.

orenyomtov commented 1 year ago

Yeah you always delegatecall to the precompile, and then the precompile either calls or static-calls, depending on the flag provided

rllola commented 1 year ago

Ah yes indeed you are right! Nice lets get this merge.