Closed nonsense closed 1 year ago
At the moment there appear to be two ways to unmarshal CIDs in this library:
readCid
writeCid
deserializeDealProposal
This results in compatibility issues with other CBOR encoding libraries.
:link: zboto Link
At the moment there appear to be two ways to unmarshal CIDs in this library:
readCid
andwriteCid
at https://github.com/Zondax/filecoin-solidity/blob/master/contracts/v0.8/cbor/FilecoinCbor.sol#L49-L77 which prepend and also drop the 0x00 byte prefix.deserializeDealProposal
(and maybe other functions?) that do not prepend on write (or drop on read) the 0x00 byte prefix -- https://github.com/Zondax/filecoin-solidity/blob/master/contracts/v0.8/cbor/MarketCbor.sol#L280-L281This results in compatibility issues with other CBOR encoding libraries.
:link: zboto Link