Zondax / ledger-icp

Apache License 2.0
16 stars 9 forks source link

ICRC1 Transfer: Change in text encoding #209

Closed lmuntaner closed 1 year ago

lmuntaner commented 1 year ago

There has been a change in the way ICRC1 account should be encoded as text.

The code of the new encoding is here.

IMPORTANT: The standard is not yet 100% confirmed, but the previous encoding should be abandoned. I'll confirm that this standard is the good one.

I rerun the icrc1 test vectors scripts:

icrc-1.json.txt

The encoded text doesn't look like a principal anymore. Therefore, I'm not sure, how it should be shown on the screen. I'd like your input regarding this.

You can find examples in the standard here.

:link: zboto Link