search

Zondax / ledger-icp

Apache License 2.0
16 stars 9 forks source link

Empty memo becomes 422710814078008 #220

Closed dskloetd closed 11 months ago

dskloetd commented 11 months ago

I noticed when confirming an ICRC-1 transfer on my Ledger Nano S that if the memo is set to the empty Uint8Array, the Ledger device displays a memo of "422710814078008". It's not necessarily a problem for us because if we just set no memo at all (so undefined), it's displayed as "0", but it seems so strange to get that number that I wanted to report it and make sure something isn't going wrong there.

cc @lmuntaner

:link: zboto Link

carlosala commented 11 months ago

Hi @dskloetd! Thanks for the report! Could I get a blob that reproduces that error? I wasn't able to reproduce with an empty memo. Thanks!

dskloetd commented 11 months ago

I'm not sure how I get a blob that reproduces the error. On the dev console, I see this. Does that help?

9c000000d9d9f7a167636f6e74656e74a46e696e67726573735f6578706972791b1788bc04f0de8e0065706174687381824e726571756573745f73746174757358204e92b2340a94a8fbca56a25b8422ab199585b5e14426d83ea78730e2921e2c9b6c726571756573745f747970656a726561645f73746174656673656e646572581d3212b82f8ce6615f06a67bb1b8d5d14191117b6a12e1c1a5c44c17ac0240010000d9d9f7a167636f6e74656e74a76361726758944449444c066d7b6e006c02b3b0dac30368ad86ca8305016e7d6e786c06fbca0102c6fcb60203ba89e5c20401a2de94eb060182f3f3910c04d8a38ca80d7d0105011dc74c68fe8ab4f8505385b02f99b5e00b306b51ffe6d0d69f17270e55020120000000000000000000000000000000000000000000000000000000000000000101904e0100000180a9a20fcdbb881780c2d72f6b63616e69737465725f69644a000000000000000201016e696e67726573735f6578706972791b1788bc04f0de8e006b6d6574686f645f6e616d656e69637263315f7472616e73666572656e6f6e636550f2d3e0211bd15cf652338988e5559c816c726571756573745f747970656463616c6c6673656e646572581d3212b82f8ce6615f06a67bb1b8d5d14191117b6a12e1c1a5c44c17ac02