Zondax / ledger-icp

Apache License 2.0
16 stars 9 forks source link

Remove Protobuf Dependency #227

Closed lmuntaner closed 7 months ago

lmuntaner commented 8 months ago

We announced in the Forum that the NNS dapp will remove the protobuf dependency.

We would like to do the same in the IC app of the Ledger.

Could you prepare a release without any of the protobuf code?

I would appreciate it if there could be extra checks to make sure we didn't forget any support for Candid. Could you give us the list of transactions that are not supported in Candid. As far as I know, only Merge Maturity should not be supported because it was deprecated.

Thanks!

:link: zboto Link

neithanmo commented 8 months ago

@lmuntaner current candid transactions supported by the ledger application:

the supported pb transactions that would be removed:

we could remove protobuf support or maybe add a compilation flag todisable/enable it.

ainhoa-a commented 8 months ago

We will remove protobuf support. No need to consider a solution with a flag.