search

Zondax / ledger-oasis

Oasis app for Ledger Nano S and X
Apache License 2.0
3 stars 6 forks source link

Adjust tx confirmation flow for Staking Add Escrow #107

Closed tjanez closed 3 years ago

tjanez commented 3 years ago

Currently, the Ledger screens for the Staking Transfer transaction are ordered as follows:

  1. Type
  2. Amount
  3. Fee
  4. Gas limit
  5. Address
  6. Genesis hash
  7. Approve

Please, re-order them to:

  1. Type
  2. To (rename Address to To to make it more clear that this is the delegation's destination account address)
  3. Amount
  4. Fee
  5. Gas limit
  6. Genesis hash
  7. Approve

This also more logically follows the Oasis Node CLI's confirmation output, e.g.:

You are about to sign the following transaction:
  Method: staking.AddEscrow
  Body:
    To:     oasis1qzn7ztfjlc962yy5yz50zt6tedl60p0aw5n98s0k
    Amount: ROSE 300.0
  Nonce:  0
  Fee:
    Amount: 0.00003 ROSE
    Gas limit: 2000
    (gas price: 0.000000015 ROSE per gas unit)
Other info:
  Genesis document's hash: e2a76b23e48639d7e08c961af77aaf55498c90fd01b70ec996d8f1906869b0d1

You may need to review the transaction on your device if you use a hardware-based signer plugin...
emmanuelm41 commented 3 years ago

This issue is already present in dev branch. It was merged with the sdk 2.0 upgrade. We could close it.

The Zemu test is here