Zondax / ledger-oasis

Oasis app for Ledger Nano S and X
Apache License 2.0
3 stars 6 forks source link

[add] CI trigger flexibility #151

Closed lpascal-ledger closed 2 years ago

lpascal-ledger commented 2 years ago

Adding CI trigger for convenience, so that PRs on external repos do embed CI status

lpascal-ledger commented 2 years ago

Would improve visibility on PR such as this one. Thanks!

jleni commented 2 years ago

Thanks @lpascal-ledger ! We will progressively add this to all other repos we manage!

tjanez commented 2 years ago

It seems good to me but we need to bump version before merging it

The thing is that Ledger already released version 2.3.2 of the Oasis app based on https://github.com/LedgerHQ/app-oasis/pull/5 so I think it would make more sense to try to merge that PR (and this one) without bumping the version?

jleni commented 2 years ago

ok, let's merge without a new version to avoid any confusion