search

Zondax / ledger-oasis

Oasis app for Ledger Nano S and X
Apache License 2.0
3 stars 6 forks source link

Make "Expert mode required" message consistent #192

Closed matevz closed 1 year ago

matevz commented 1 year ago

When signing transaction which requires expert mode, the current UI on my Nano S is slightly broken (see attachment).

If possible, use "This app is not genuine" interface with an exclamation mark on the left

Signing rejected
Expert mode required

No left-right screens needed, double-click should hide the message.

IMG_20230213_115114297

:link: zboto Link

chcmedeiros commented 1 year ago

Hey! I already fixed the message in the latest push to be:

Signing rejected
Expert mode required

Regarding the "This app is not genuine" ui, I will add that interface on the app opening.

matevz commented 1 year ago

I checked the new version and the typo was fixed, thanks.

My suggestion was that the UI for errors/warnings should be made consistent across the app. A small checkmark on the right with the right-click to continue is currently not intuitive. Either there should be a separate "Cancel" screen with double-click to hide it or a single error screen with a triangle ! icon on the left and double-click hides it.

chcmedeiros commented 1 year ago

Hey @matevz this should be fixed in the latest changes of M3-maintenance