search

Zondax / ledger-rust

Apache License 2.0
2 stars 4 forks source link

Support more curves #8

Open ghost opened 2 years ago

ghost commented 2 years ago

This is an issue for the bolos family of crates, not the app itself

Currently in our bolos wrapper crate we only support 3 curves, while the full ledger SDK makes use of many more.

We need to define a design to encopass all these curves and also find a way to make it ergonomic to use in rust so that we can build apps more easily in the future. We also need to actually implement bindings and methods to use these curves!

/cc @jleni @leongb @neithanmo

See https://github.com/Zondax/ledger-tezos/blob/ef4425540c7425b359e4112c52e07f4520207765/rust/bolos-impl/src/crypto/ecfp256.rs#L148 https://github.com/Zondax/ledger-tezos/blob/ef4425540c7425b359e4112c52e07f4520207765/rust/bolos-impl/src/crypto/ecfp256.rs#L150 https://github.com/Zondax/ledger-tezos/blob/ef4425540c7425b359e4112c52e07f4520207765/rust/bolos-impl/src/crypto/ecfp256.rs#L39

:link: zboto Link

ghost commented 2 years ago

Also related https://github.com/Zondax/ledger-tezos/blob/ef4425540c7425b359e4112c52e07f4520207765/rust/bolos-impl/src/crypto/ecfp256.rs#L139

jleni commented 2 years ago

This has proven to be inflexible and too complicated. We should flatten a bit more the API and make it more similar to bolos instead.