Zondax / ledger-tezos

Apache License 2.0
8 stars 5 forks source link

Complete tests #154

Open ghost opened 2 years ago

ghost commented 2 years ago

There are some tests left incomplete, either for lack of mock bindings previously or not knowing how to continue.

Such an example is: https://github.com/Zondax/ledger-tezos/blob/ef4425540c7425b359e4112c52e07f4520207765/rust/app/src/handlers/public_key.rs#L389 The test was left incomplete due to the missing mock bindings, the intended completion is checking the validity of the generate public key.

Something similar applies also to some of our Zemu test, where a proper library has not been found to verify the output of our APDUs. See: https://github.com/Zondax/ledger-tezos/blob/ef4425540c7425b359e4112c52e07f4520207765/zemu/tests/baking.test.ts#L608 https://github.com/Zondax/ledger-tezos/blob/ef4425540c7425b359e4112c52e07f4520207765/zemu/tests/standard.test.ts#L197 https://github.com/Zondax/ledger-tezos/blob/ef4425540c7425b359e4112c52e07f4520207765/zemu/tests/standard.test.ts#L251 https://github.com/Zondax/ledger-tezos/blob/ef4425540c7425b359e4112c52e07f4520207765/zemu/tests/testvectors.test.ts#L77 https://github.com/Zondax/ledger-tezos/blob/ef4425540c7425b359e4112c52e07f4520207765/zemu/tests/testvectors.test.ts#L139

:link: zboto Link

ghost commented 2 years ago

There are also some newer APDUs that lack some unit tests